Simplify Windows read-only file deletion#200
Merged
Merged
Conversation
VitjanZ
approved these changes
May 28, 2026
| try: | ||
| os.remove(entry.path) | ||
| except PermissionError: | ||
| os.chmod(entry.path, stat.S_IWRITE) |
Collaborator
There was a problem hiding this comment.
If the permissions weren't the reason the os.remove fails then this causes the process to crash?
Contributor
Author
There was a problem hiding this comment.
Yeah, I guess it would cause the process to crash if there's a different reason. But that would happen now too and we can handle that when we find such a case. Nice find though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.walk+_make_writablelogic withshutil.rmtree's built-inonerrorhandler.git/objectsfiles on WindowsRelates to https://github.com/Codeplain-ai/next-microsoft/issues/5 (point 2: investigate if folders can be created with proper permissions instead of using
make_writable).Test plan